Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade go min version to 1.20 #219

Merged
merged 1 commit into from
Apr 11, 2023
Merged

feat: upgrade go min version to 1.20 #219

merged 1 commit into from
Apr 11, 2023

Conversation

kushsharma
Copy link
Member

  • this is required as 1.20 fixes an essential http.Cookie expiry bug

@kushsharma kushsharma force-pushed the go-1.20 branch 2 times, most recently from f86187f to b8c142b Compare April 11, 2023 03:47
@kushsharma kushsharma marked this pull request as ready for review April 11, 2023 03:48
@coveralls
Copy link

coveralls commented Apr 11, 2023

Pull Request Test Coverage Report for Build 4665749626

  • 13 of 22 (59.09%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 55.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/serve_proxy.go 0 1 0.0%
internal/store/spicedb/schema_generator/generator.go 13 21 61.9%
Files with Coverage Reduction New Missed Lines %
cmd/serve_proxy.go 1 0%
Totals Coverage Status
Change from base Build 4663612042: -0.02%
Covered Lines: 4702
Relevant Lines: 8399

💛 - Coveralls

@kushsharma kushsharma force-pushed the go-1.20 branch 2 times, most recently from bb45d4b to 620d675 Compare April 11, 2023 03:58
- this is required as 1.20 fixes an essential http.Cookie expiry bug

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@kushsharma kushsharma merged commit 1f35ea2 into main Apr 11, 2023
3 checks passed
@kushsharma kushsharma deleted the go-1.20 branch April 11, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants