feat(api): add search API #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ramey
force-pushed
the
search
branch
3 times, most recently
from
a5a02f2
to
909de12
Compare
ravisuhag
reviewed
Feb 9, 2022
Closed
- create `SearchService` and `SearchRepository` interfaces - add mocks generated by mockery for the interfaces - update auto-generated go files for new RPC call and messages - add DB query for searching data in Postgres - migrate scripts for index creation on search_data
* modify search API to make it a global search instead of schema search * add search keys by parsing comments for protobufs
* change `all` param in `SearchRequest` to `history` * use oneof for `version_id` and `history`
ramey
force-pushed
the
search
branch
2 times, most recently
from
5cef43c
to
0b7a0eb
Compare
address review comments by @ravisuhag and @harikrishnakanchi
* removed indexes on json fields in * updated search query to search on proto fullname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SearchServiceandSearchRepositoryinterfaces