feat: add refresh strategy to stencil client #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4rikris
force-pushed
the
refresh-strategy-go
branch
2 times, most recently
from
b8b1cb3
to
ea34484
Compare
BREAKING CHANGE: * Removed NewMultiURLClient method. * Changed NewClient method to accept list of urls, instead of just taking one * Removed ParseWithRefresh, SerializeWithRefresh methods from Client interface * Changed Refresh method signature from `Refresh() error` to `Refresh()`
h4rikris
force-pushed
the
refresh-strategy-go
branch
from
ea34484
to
36b23f9
Compare
h4rikris
force-pushed
the
refresh-strategy-go
branch
from
36b23f9
to
be77c2e
Compare
pyadav
reviewed
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Refresh() errortoRefresh()