Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quill::detail::get_error_message multiple definition #469

Closed
RazielXYZ opened this issue Jun 12, 2024 · 1 comment · Fixed by #470
Closed

quill::detail::get_error_message multiple definition #469

RazielXYZ opened this issue Jun 12, 2024 · 1 comment · Fixed by #470

Comments

@RazielXYZ
Copy link

RazielXYZ commented Jun 12, 2024 •
edited
Loading

Version: 4.0.0 and up
When including quill/Backend.h in different compilation units, we are getting an error for multiple definition of quill::detail::get_error_message. From looking at it, it looks like that function should be inline.
Thanks!
@odygrd odygrd linked a pull request Jun 13, 2024 that will close this issue
Fix multiple definitions of quill::detail::get_error_message #470
Merged
@odygrd
Copy link
Owner

odygrd commented Jun 13, 2024 •
edited
Loading

thanks for reporting : ) It seems that this is only affecting Windows builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix multiple definitions of quill::detail::get_error_message odygrd/quill
2 participants
@odygrd @RazielXYZ