Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong call for the f1 score? #6

Closed
GiorgioCrasto opened this issue Aug 29, 2018 · 2 comments
Closed

Wrong call for the f1 score? #6

GiorgioCrasto opened this issue Aug 29, 2018 · 2 comments

Comments

@GiorgioCrasto
Copy link

in DAE-example.ipynb the F1 score should be called with rpaf[3]? It should be .45701927 for the example given.

import metrics
rpaf = metrics.recall_precision_accuracy_f1(predicted, ground_truth)
print("============ Recall: {}".format(rpaf[0]))
print("============ Precision: {}".format(rpaf[1]))
print("============ Accuracy: {}".format(rpaf[2]))
print("============ F1 Score: {}".format(rpaf[2]))

print("============ Relative error in total energy: {}".format(metrics.relative_error_total_energy(predicted, ground_truth)))
print("============ Mean absolute error(in Watts): {}".format(metrics.mean_absolute_error(predicted, ground_truth)))

@OdysseasKr
Copy link
Owner

You are right. Same for the rest of the ipynd. If you have corrected this, feel free to submit a pull request. Otherwise, I am going to fix this in the following days.

Thank you for submitting the issue 👍

@GiorgioCrasto
Copy link
Author

Hi!
thanks for the prompt replay. Unfortunately I don't have access to the REDD database since I am not part of an academic institute so I cannot test my changes at that level of the notebook.
I am trying to re run the notebook with the UKDALE dataset but I am getting into another trouble with the metadata of the hdf5 file.
So if you like to make the change by your self feel free to do it; I am not ready yet.
Many thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants