-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove peer dependency on express #52
Comments
Yeah, I've known that was a little silly to have in there for awhile, since if someone wasn't using express, they'd get the whole package. I think if we move it to |
I've just had a look at this and It doesn't feel like there's a nice solution to this. I wonder which is the most common version of npm in use? v2 or v3? I think the biggest value of this module is the react component and lifecycle bit. Generating the signed url is the easy bit. It might be worth removing the express section completely and just improving the docs to explain what's required from the user's backend. What do you think? |
Could also just remove the dependency altogether, since someone who is using express will naturally already have the dependency specified elsewhere. Then if you aren't using express and never import the router, it wouldn't be a problem. |
see #53. Let me know what you think |
Merged #53 and published |
I'm using hapi instead of express yet I now have both installed just to use this lib. When using npm v2 peer dependencies are automatically installed.
I'm not sure if there is anything I can do to prevent having both express and hapi installed, except upgrade to npm v3.
Any thoughts?
The text was updated successfully, but these errors were encountered: