Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of files in Movies directory/folder #36

Open
klorinczi opened this issue Mar 29, 2024 · 2 comments
Open

Number of files in Movies directory/folder #36

klorinczi opened this issue Mar 29, 2024 · 2 comments
Labels
Feature Request 💡 Bring your ideas

Comments

@klorinczi
Copy link

Is your feature request related to a problem? Please describe.
I really miss the number of files in a Movies directory/folder.

Currently shows:
media / usb / movie [ 24 movies ] / ↳ Subdirectories (dropdown menu)
.Trash
TV show1 directory
TV show2 directory
TV show3 directory

Describe the solution you'd like
Feature request to show:
media / usb / movie [ 24 movies ] / ↳ Subdirectories (dropdown menu)
.Trash [ 12 movies ]
TV show1 directory [ 18 movies ]
TV show2 directory [ 0 movies ]
TV show3 directory [ 3 movies ]

Note the number of files in subdirectory/subfolder shown in parentheses.

This should be an easy fix.

@klorinczi klorinczi added the Feature Request 💡 Bring your ideas label Mar 29, 2024
@jbleyel
Copy link
Contributor

jbleyel commented Mar 29, 2024

No .. that's not easy because the files inside of a subfolder will be read if you select the folder and not before.
Scanning of all subfolder will take a lot of time depending on the content.
This will be a massive performance problem especially if you have NAS.

@klorinczi
Copy link
Author

klorinczi commented Mar 29, 2024

Well, you are right, it may affect performance in some situations.
It may not as easy as I imagined.

But it can be handled in separate ways.

Likely there will be no performance problems with external SATA disks attached on USB port until a few hundreds of files per directory.
It is possible to cache subdir numbers, display cached numbers, refresh rarely.

It may really mean performance problem for network attached devices (NAS).
But network devices can be detected, so subdir counting can be disabled for networking devices.

There are several possible ways for solution:

  1. New option in Settings:
    Subdirectory movie counting for external : [ X ] Yes (default) [ ] No

  2. New option in Settings:
    Subdirectory movie counting for network drives: [ ] Yes [ X ] No (default)

  3. New option in Settings:
    Subdirectory movie counting (cache movie count): [ X ] Yes (default) [ ] No

  4. New option in Settings:
    Subdirectory movie counting - (display [ # ] character above [ 500 ] ) movies: [ X ] Yes (default) [ ] No

Implementing these options, performance problems could be handled.

What do you think @jbleyel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request 💡 Bring your ideas
Projects
None yet
Development

No branches or pull requests

2 participants