Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - Merge 2.3 into master. #50

Closed
jbleyel opened this issue Apr 27, 2015 · 10 comments
Closed

Question - Merge 2.3 into master. #50

jbleyel opened this issue Apr 27, 2015 · 10 comments
Labels

Comments

@jbleyel
Copy link
Contributor

jbleyel commented Apr 27, 2015

Some Images use the master branch with some old code and some missing fixes.

What you think about the merge into master step by step?

@Schimmelreiter
Copy link
Member

I think that's the duty of the image teams that use master.
And if we merged the changes, they could as well switch to 2.3 or 3.0 ...

So I guess if they use an old branch, they do it intentionally.
2.3 also lacks some of the fixes that 3.0 has ... though it makes sense for some boxes to stick with 2.3.

@jbleyel
Copy link
Contributor Author

jbleyel commented Apr 27, 2015

3.0 ?

@Schimmelreiter
Copy link
Member

Ah, I see the plugins do not have a separate 3.0 branch ...

Anyways, I think it's up to the teams to use the branch they prefer.
Where would be the point of two identical branches after merging all diffs into master?

@jbleyel
Copy link
Contributor Author

jbleyel commented Apr 27, 2015

The master should be include the latest commit's and all other branches should only be used for maintenance fixes.
All old / unused branches should be archived and deleted.

IMHO

@jbleyel
Copy link
Contributor Author

jbleyel commented Apr 27, 2015

What you think about:

Rename the master to 2.0 maintenance
+
Rename the 2.3 to master
+
Merge all missing commit's from the "2.0 maintenance" to master

!! This is a question to all. !!

@atvcaptain
Copy link
Member

we have teams do not want the changes from 2.3.
The master is out of support for me.
Use the 2.3 we dont merge back all to master, the master is the orign branch from this git so that is the problem ?
Then i get info master not needed any more we can start delete the old master

@jbleyel
Copy link
Contributor Author

jbleyel commented Apr 28, 2015

I'm not a git specialist, rename the master to old and rename the 2.3 to master should be not a problem.
Setting the new master as new origin ???? I don't know.

@AbuBaniaz
Copy link
Contributor

Might be an idea to start deleting branches that are no longer used.

@atvcaptain
Copy link
Member

no we need the history to check infos

@AbuBaniaz
Copy link
Contributor

There have been no commits for over a year. other than merges of pull requests which i'm sure were submitted to what the submitter thought was the current branch.

Maybe rename to Master-Not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants