Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD4linux #781

Closed
Marchella1983 opened this issue May 23, 2024 · 8 comments
Closed

LCD4linux #781

Marchella1983 opened this issue May 23, 2024 · 8 comments

Comments

@Marchella1983
Copy link

Good afternoon! Dear developers please add these improvements to the plugin ce2c6e7 to the plugin...

@MrServo
Copy link
Contributor

MrServo commented May 23, 2024

Good morning!
The suggestions have long since been incorporated into LCD4linux:
e149b03
Regards....Mr.Servo

@Marchella1983
Copy link
Author

Yes, but not all of them.

There is one small problem with viewing IPtv as media and there is a fix for it.
2afb05d

please make changes to that too.

@MrServo
Copy link
Contributor

MrServo commented May 24, 2024

Done! I hope I have now transferred all the suggested changes correctly...
#782

@Marchella1983
Copy link
Author

Done! I hope I have now transferred all the suggested changes correctly... #782

Thank you so much! Everything's fine now.

@jbleyel jbleyel closed this as completed May 24, 2024
@Marchella1983
Copy link
Author

one more correction
If self.Lpath and self.Lpath.startswith("http") and self.Llength and self.Llength[0] == -1:

replace with
if self.Lpath and self.Lpath.startswith((("http", "https")) and self.Llength and self.Llength[0] == -1:

Tnx @Dorik1972!

@jbleyel
Copy link
Contributor

jbleyel commented May 25, 2024

This change makes no difference to me.

@Marchella1983
Copy link
Author

This change makes no difference to me.

I'm sorry! It may not matter to you, but it does to us.

Is it a problem for you to correct this part of the code?

if self.Lpath and self.Lpath.startswith("http") and self.Llength and self.Llength[0] == -1:

@jbleyel
Copy link
Contributor

jbleyel commented May 25, 2024

>>> Lpath = "https"
>>> Lpath.startswith("http")
True
>>>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants