Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

znapzend.service points to wrong location of installation #305

Closed
averyfreeman opened this issue Dec 9, 2017 · 2 comments
Closed

znapzend.service points to wrong location of installation #305

averyfreeman opened this issue Dec 9, 2017 · 2 comments
Labels

Comments

@averyfreeman
Copy link

averyfreeman commented Dec 9, 2017

Hi! Thanks for the great program. I have installed it on my Arch laptop with ZFS root.

I noticed when # make install installed znapzend, it placed executables in /opt/znapzend-0.17.0/bin/

However, the init service packaged in the git repo points to: ExecStart=/usr/local/bin/znapzend

Is this expected behavior? Is there something I missed in the installation where symlinks are installed?

Here's my original copy of znapzend.service:

description "znapzend"

respawn

start on [2345]
stop on runlevel [06]

expect fork
reload signal HUP

exec /usr/local/bin/znapzend --daemonize
[avery@ant520 init]$ cat znapzend.service
[Unit]
Description=ZnapZend - ZFS Backup System
Documentation=man:znapzend
After=zfs-import-cache.service
After=zfs-import-scan.service

[Service]
ExecStart=/usr/local/bin/znapzend
ExecReload=/bin/kill -HUP $MAINPID
Restart=on-failure
# might be neccessary on low power systems
# Nice=19
# IOSchedulingClass=2
# IOSchedulingPriority=7

[Install]
WantedBy=multi-user.target

Here's the version I edited for my laptop:

[Unit]
Description=ZnapZend - ZFS Backup System
Documentation=man:znapzend
After=zfs-import-cache.service
After=zfs-import-scan.service

[Service]
ExecStart=/opt/znapzend-0.17.0/bin/znapzend
ExecReload=/bin/kill -HUP $MAINPID
Restart=on-failure
# might be neccessary on low power systems
Nice=19
IOSchedulingClass=2
IOSchedulingPriority=7

[Install]
WantedBy=multi-user.target

Did I do that right?

@jimklimov
Copy link
Contributor

Hello, the "original copy" looks like an upstart manifest, not as a systemd service (unlike the second block in your paste).

Indeed, until recently the /usr/local/bin paths were hardcoded there, and should now be generated to correspond to configured values since PRs #340 and #348

@stale
Copy link

stale bot commented Jun 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 28, 2021
@stale stale bot closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants