Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card-img-top not placed correctly #30

Closed
Hasenhirn opened this issue Dec 30, 2021 · 2 comments
Closed

card-img-top not placed correctly #30

Hasenhirn opened this issue Dec 30, 2021 · 2 comments

Comments

@Hasenhirn
Copy link

Setup and configuration

  • MW version: 1.35.5
  • PHP: 7.4.27
  • DB (MySQL etc.): 10.6.5-MariaDB
  • Skin (version): Chameleon 3.4.1
  • Bootstrap: 4.5.0
  • BootstrapComponents: 4.0.1
  • Link_Attributes: 1.1

Issue

  • Missing card-img-top option
  • Card Header Images not filling the whole heading, parser prepends div.card-header and puts Image in h4 container

Produces a stack trace and outputs:

Steps to reproduce the observation (recommendation is to use the sandbox):

The code below shows the different approaches. and Outcomes

<div class="row">
<div class="col-3">
<div class="card">[[Datei:180x100.png|class=card-img-top|alt=Card image cap]]
<div class="card-body">
<h5 class="card-title">Card title</h5>
<p class="card-text">Some quick example text to build on the card title and make up the bulk of the card's content.</p>
[[Hallo|Klick mich ((.btn .btn-primary))]]
</div>
</div>
</div>
<div class="col-3">
<bootstrap_card header="[[Datei:180x100.png|class=card-img-top|alt=Card image cap]]">
<h5 class="card-title">Card title</h5>
<p class="card-text">Some quick example text to build on the card title and make up the bulk of the card's content.</p>
[[Hallo|Klick mich ((.btn .btn-primary .text-white))]]
</bootstrap_card>
</div>
</div>

2021-12-30 08_59_28-Window

Possible solutions:

  • Implement a seperate header_image attribute
  • Check if [[File: is referenced in wiki markup and let the paser place the image accordingly

P.S.: Thank you very very much for your work!!!!

@oetterer
Copy link
Owner

hey @Hasenhirn. I followed your suggestion and added a header-image (and footer-image) attribute. Unfortunately, for now you need to supply the appropriate class manually.

ps: sorry, it took so long.

@oetterer
Copy link
Owner

@Hasenhirn its me again. Found a way to take care of the required css classes for footer and header images. no need to supply them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants