Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Office.ASP.NETCoreReactAddins uses .Net Core 2.2 Runtime which is EOL #77

Closed
MarkIannucci opened this issue May 12, 2020 · 3 comments
Closed

Office.ASP.NETCoreReactAddins uses .Net Core 2.2 Runtime which is EOL #77

MarkIannucci opened this issue May 12, 2020 · 3 comments
Labels
needs triage 🔍

Comments

@MarkIannucci
Copy link

.Net Core 2.2 was EOL 12/23/2019. It would be great if someone can update the sample to 3.1.
@ghost ghost added the needs triage 🔍 label May 12, 2020
@aafvstam
Copy link
Collaborator

Well, you are in luck ... I already did the work and created a PR #75 for this here and waiting for it to be merged. Initially only upgraded the TypeScript part as I wanted to get this pulled in before putting in more work to also update the JaveScript part. The PR has been sitting here now for a couple of weeks without any interaction so not sure what is going on. Maybe they plan to surprise us at Build 2020 next week ;-)

@MarkIannucci MarkIannucci mentioned this issue May 12, 2020
Merged
@MarkIannucci
Copy link
Author

@aafvstam , thank you. I am in luck; I'll use your fork until the PR gets merged.

@Rick-Kirkham
Copy link
Contributor

Sorry for the delay. The PR is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage 🔍
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aafvstam @Rick-Kirkham @MarkIannucci