Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostics.hostname values are incorrect #469

Closed
freerangeeggs opened this issue Aug 5, 2019 · 4 comments
Closed

diagnostics.hostname values are incorrect #469

freerangeeggs opened this issue Aug 5, 2019 · 4 comments

Comments

@freerangeeggs
Copy link

freerangeeggs commented Aug 5, 2019

The hostname field states that:
A string that can be one of the following values: Outlook, Mac Outlook, OutlookIOS, or OutlookWebApp.

This is not the case.

  • When running Outlook on a Mac, the value returned is Outlook, not Mac Outlook. This is has been the case since 1.0
  • Additionally, it can return OutlookAndroid.

I propose you change to:
A string that can be one of the following values: Outlook, OutlookAndroid, OutlookIOS, or OutlookWebApp.

This was already brought up in issue #461 (resolved via #467) but I cannot see the changes on this page, which looks to be a new URL compared to when I added the original issues.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@ElizabethSamuel-MSFT
Copy link
Contributor

@freerangeeggs The fixes haven't been published yet but should go live soon (likely tomorrow). The URLs are different because we updated how the reference documentation is organized.

I'll close this for now as the PRs referenced in the original issues should be the fix. If they do not fix them, let us know.

Thanks.

@freerangeeggs
Copy link
Author

Hi @ElizabethSamuel-MSFT
Thanks for your response, but I am not seeing the change in the docs. How can this be considered closed?

@ElizabethSamuel-MSFT
Copy link
Contributor

@freerangeeggs The changes should be live now. Can you confirm? Thanks.

@freerangeeggs
Copy link
Author

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants