You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
In a browser the Utilities.isAddin check return true, even when using it outside of Office. This results in the helpers trying to use the Dialog framework to open an authentication window instead of a normal browser popup.
We are still experiencing this issue on our application. Has the bug returned?
Let me know if you want reproduction steps
EDIT: Looks like the issue is that you haven't published a new package. Isn't it time to do it soon since its been a few months? Who is the owner of this package and can publish it to npm?
We have built our own dist file from the source for now.
This project is dead, I guess. Nobody bothers to merge PR's or is following up on issues.
Since we invested in using this library, we are building from source (and implemented some other PR's as well) and continue that way until we can strip out this dependency.
That is sad. Really handy functions for us. Would it be possible for your team to do a fork of this project? Maybe we can help each other out if there are issues and for feature implementation.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In a browser the Utilities.isAddin check return true, even when using it outside of Office. This results in the helpers trying to use the Dialog framework to open an authentication window instead of a normal browser popup.
Problematic code:
office-js-helpers/src/helpers/utilities.ts
Line 180 in a7b0282
When used in the browser, the
host
property is undefined. This doesn't equal WEB and therefor it is considered being in an AddIn.Not sure who owns this anymore, so I'm tagging all: @casieber, @Zlatkovsky, @sumurthy & @LouMM
The text was updated successfully, but these errors were encountered: