Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

IsAddin check fails in Browser, still returns true and uses Dialog framework #133

Closed
YannickRe opened this issue May 6, 2019 · 3 comments · Fixed by #135
Closed

IsAddin check fails in Browser, still returns true and uses Dialog framework #133

YannickRe opened this issue May 6, 2019 · 3 comments · Fixed by #135

Comments

@YannickRe
Copy link

YannickRe commented May 6, 2019

In a browser the Utilities.isAddin check return true, even when using it outside of Office. This results in the helpers trying to use the Dialog framework to open an authentication window instead of a normal browser popup.

Problematic code:

return Utilities.host !== HostType.WEB;

When used in the browser, the host property is undefined. This doesn't equal WEB and therefor it is considered being in an AddIn.

Not sure who owns this anymore, so I'm tagging all: @casieber, @Zlatkovsky, @sumurthy & @LouMM

Zlatkovsky added a commit to Zlatkovsky/office-js-helpers that referenced this issue May 6, 2019
Before this fix, "host" would return "undefined" instead of web.
This also fixes OfficeDev#133
@jacob-j
Copy link

jacob-j commented Sep 26, 2019

We are still experiencing this issue on our application. Has the bug returned?
Let me know if you want reproduction steps

EDIT: Looks like the issue is that you haven't published a new package. Isn't it time to do it soon since its been a few months? Who is the owner of this package and can publish it to npm?

We have built our own dist file from the source for now.

@YannickRe
Copy link
Author

This project is dead, I guess. Nobody bothers to merge PR's or is following up on issues.
Since we invested in using this library, we are building from source (and implemented some other PR's as well) and continue that way until we can strip out this dependency.

@jacob-j
Copy link

jacob-j commented Sep 26, 2019

That is sad. Really handy functions for us. Would it be possible for your team to do a fork of this project? Maybe we can help each other out if there are issues and for feature implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants