Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Authenticator: Make width and height of dialog window configurable #146

Open
jsaele opened this issue Sep 27, 2019 · 0 comments
Open

Authenticator: Make width and height of dialog window configurable #146

jsaele opened this issue Sep 27, 2019 · 0 comments

Comments

@jsaele
Copy link

jsaele commented Sep 27, 2019

When using office-js to create a dialog window it's possible to configure the size of the window.

Authenticator uses this under the hood, but it's not avaliable to configure for users. Seems to be hardcoded in authenticator.ts:153:

let redirectUrl = await new Dialog<string>(url, 1024, 768, useMicrosoftTeams).result;

Please correct me if I'm wrong.

I propose a change where we either add the params width and height, or an option obj, to either the Authenticator constructor or the authenticate method.

Could possibly change the constructor of Authenticator to just be an option object, but that would be a breaking change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant