-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom function "error installing functions" via Admin Managed. Working on Local and Sideload #4571
Comments
Hi @mowglimecha9 Thanks for reporting this issue. Could you please share us the manifest? We're trying to repro and look into this issue. |
Sure. This is the manifest! @shanshanzheng-dev |
Hi @mowglimecha9 Thanks. We'll be looking into this issue. We'll report back if we have a suggestion for you. |
@shanshanzheng-dev Thanks for the help. We are getting ready for a release in appsource as we speak. |
Hi @mowglimecha9, thanks for waiting. I try to deploy the add-in you provided via Admin Managed but found it works as expeted. Below are some snapshot: Also, I see the add-in is still under implementation, so I guess is it possible that you install your add-in twice(sideload and admin managed) in your environment and it causes some name conflict? If that is the case, I'd suggest you keep only 1 manifest in your environment either sideload or admin managed. |
@XuanZhouMSFT Thanks for the reply! We've tried everything and even cleared cache and also we made it so that we have one manifest. But still getting "Error Loading functions" |
Sorry to hear that. We tried your add-in both in Win32 Excel(17726.20078) and MAC Excel (16.86), and they both works well. :( |
We will try to upload the add-in again and check and let you know. But whats the correct way of doiing it in admin managed? should we delete and upload? or replace will do? |
I didn't do that before. But perhaps do a delete first and clear cache may help to avoid some cache problem? |
|
Hi @XuanZhouMSFT i've uploaded the current manifest file in the admin managed tab. It works well but while loading the or adding the add-in through the store. Im seeing glimpse of "Error loading add-ins" in the bar below the task pane. However it will disappear after 1 sec. Also we want to rely on admin managed than side loading the add-in thats why this is quite important. |
Hi @mowglimecha9 , the admin managed and side loading add-in are both supported. You can choose either one of them to deploy your add-in. If your customer only got the admin-managed add-in, they do not need to manually clear the cache. In my understanding, the issue you posted in the beginning is caused by the several same add-ins deployed by both sideload and admin-managed. So if you only have 1 way to deploy your add-in, the customer will not hit it. And also add one more information. If you already have some old files which used the add-in deployed by sideload, it will cause some problems. Because we will save the add-in location into the files. It means, in the past, you used the sideload add-in and custom function in the file, we will save the add-in information with the sideload information into the file. While you open the file again, we will rely on the saved add-in information and try to load it from sideload. |
We have submitted our app With this new xml format (sent as text file as we cannot put xml here)) |
The #NAME most probobly caused by customer function not register well. Either resource download fail, name conflict or any other issues. From your original description, it's caused by name confliction. |
But this one is from the MSFT testing team when we are trying to publish the app in the appSource. They are testing in web! and It's working in Mac and Windows. So it raises a question here on how they are doing the uploads . There are no issues on our end if we test this. Its just in MSFT approval or tester side @XuanZhouMSFT |
@mowglimecha9 Just want to double check with you. So the question changes, the current problem happens when you want to upload the manifest into the store? When you update the manifest and want to publish it via store. And the approve team from Microsoft have the #NAME issue when they try the add-in from Excel online? |
Yep that is correct |
@XuanZhouMSFT Hi any updates on this? Thank you |
Hi @XuanZhouMSFT @shanshanzheng-dev @wamaina We are encountering an issue in web browsers where we cannot retrieve the custom functions signature. While we have managed to narrow it down to custom functions not working, we are unsure of the exact cause. We suspect it may be due to the custom functions not being installed or added correctly during web browser usage - OWA. For example, custom functions like: These functions work fine in the desktop Excel application but do not work in Excel on the web browser. How can we resolve this? We have an open ticket for this issue: • Request ID: 111642 We have included the video clip for the issue in the zip file and the repro steps here. Content requirement - 1120.3.2.2 Online Chrome Certification Failure report: |
@jwongyh Thanks for the waiting. |
Hi @XuanZhouMSFT and team. We can close this ticket now. It turns out the problem was a CORS policy in our s3 bucket. Thanks so much for the help! |
Provide required information needed to triage your issue
We have an admin managed add-in. Everytime we initialize it its saying "Error installing functions"
We have checked everything from the functions.json to local and sideload. It works
Our manifest is valid aswell
Your Environment
Expected behavior
It should show all our functions after we trigger
={NAMESPACE
but nothing shows. We have a login and a taskpane that fetches apis those work. But not the custom functions.We have done it a lot of times we push our changes and it appears. But for some reason that started yesterday night the custom functions now doesn't load. Which results to # NAME? error on our workbook.
Current behavior
It just showing us name.
Steps to reproduce
={Namespace}
and see if it shows.Provide additional details
Below are the logs. It stops after installing. It's not verbose enough
The text was updated successfully, but these errors were encountered: