Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix broken link on importing employees #1015

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Jun 8, 2021

Close #1014

@djaiss djaiss enabled auto-merge (squash) June 8, 2021 16:04
@djaiss djaiss merged commit 772df31 into main Jun 8, 2021
@djaiss djaiss deleted the 2021-06-08-fix-broken-link branch June 8, 2021 20:01
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@asbiin
Copy link
Contributor

asbiin commented Jun 9, 2021

I've fixed it some days ago adding url in :href, and it worked. What was wrong @djaiss ?

@djaiss
Copy link
Member Author

djaiss commented Jun 9, 2021

@asbiin it can't work.

$page.props.help_links.import_employees simply gives manage/employee-management.html#importing-employees. It doesn't know how to add https://docs.officelife.... at the beginning of the URL.

@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Not Found CSV Import
2 participants