Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix age calculation using timezone #1038

Merged
merged 4 commits into from
Jun 13, 2021
Merged

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Jun 12, 2021

This fix #1013

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from djaiss June 12, 2021 09:34
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few grammar mistakes, otherwise it's all good.

tests/Unit/Helpers/BirthdayHelperTest.php Outdated Show resolved Hide resolved
tests/Unit/Helpers/BirthdayHelperTest.php Outdated Show resolved Hide resolved
tests/Unit/Helpers/BirthdayHelperTest.php Outdated Show resolved Hide resolved
tests/Unit/Helpers/BirthdayHelperTest.php Outdated Show resolved Hide resolved
tests/Unit/Helpers/BirthdayHelperTest.php Outdated Show resolved Hide resolved
asbiin and others added 2 commits June 12, 2021 23:34
Co-authored-by: Regis Freyd <djaiss@users.noreply.github.com>
Co-authored-by: Regis Freyd <djaiss@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 72c5373 into main Jun 13, 2021
@asbiin asbiin deleted the 20210612-fix-age-calculation branch June 13, 2021 06:13
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in age calculation
2 participants