Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sentry logger channel #1046

Merged
merged 3 commits into from
Jun 14, 2021
Merged

feat: add sentry logger channel #1046

merged 3 commits into from
Jun 14, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Jun 14, 2021

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from a team as a code owner June 14, 2021 05:52
@asbiin asbiin requested review from djaiss and removed request for a team June 14, 2021 05:52
@sentry-io
Copy link

sentry-io bot commented Jun 14, 2021

Sentry issue: FORTRABBIT-K

djaiss
djaiss reviewed Jun 14, 2021
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically we add a new way of logging errors?

@asbiin
Copy link
Contributor Author

asbiin commented Jun 14, 2021

@djaiss exactely. It allows logging errors, or upper level messages - see https://laravel.com/docs/8.x/logging#writing-log-messages
They are not exception that are not catch, but they will end up to sentry as well.

@sonarcloud
Copy link

sonarcloud bot commented Jun 14, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@asbiin asbiin merged commit 811fd3a into main Jun 14, 2021
@asbiin asbiin deleted the 20210614-sentrylog branch June 14, 2021 19:54
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbiin @djaiss