Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hire candidate #1279

Merged
merged 15 commits into from
Aug 27, 2021
Merged

feat: hire candidate #1279

merged 15 commits into from
Aug 27, 2021

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Aug 24, 2021

This PR lets HR actually hire a candidate.

Hiring a candidate means that the candidate will be converted to an employee in the system.

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 22%, saving 2.15 KB.

Filename Before After Improvement Visual comparison
public/img/streamline-icon-finish-line-6@100x100.png 9.78 KB 7.63 KB -22.0% View diff

63 images did not require optimisation.

@djaiss djaiss marked this pull request as ready for review August 26, 2021 01:59
@djaiss djaiss requested a review from a team as a code owner August 26, 2021 01:59
@djaiss djaiss requested review from asbiin and removed request for a team August 26, 2021 01:59
Copy link
Contributor

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
See my comments ;)

use App\Services\Company\Employee\HiringDate\SetHiringDate;
use App\Services\Company\Adminland\Employee\AddEmployeeToCompany;

class HireCandidate extends BaseService
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be run on the queue?

@djaiss djaiss added the auto-squash Auto-completes a PR when reviews and checks pass label Aug 27, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

92.9% 92.9% Coverage
6.3% 6.3% Duplication

@djaiss djaiss merged commit 4ef1544 into main Aug 27, 2021
@djaiss djaiss deleted the 2021-08-24-select-candidate branch August 27, 2021 12:32
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-squash Auto-completes a PR when reviews and checks pass released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants