-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hire candidate #1279
feat: hire candidate #1279
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 22%, saving 2.15 KB.
63 images did not require optimisation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
See my comments ;)
use App\Services\Company\Employee\HiringDate\SetHiringDate; | ||
use App\Services\Company\Adminland\Employee\AddEmployeeToCompany; | ||
|
||
class HireCandidate extends BaseService |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be run on the queue?
resources/js/Pages/Dashboard/HR/JobOpenings/Candidates/Hire.vue
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
🎉 This PR is included in version 0.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This pull request has been automatically locked since there |
This PR lets HR actually hire a candidate.
Hiring a candidate means that the candidate will be converted to an employee in the system.