feat: add ability to post comment to project messages #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 21.4%, saving 936 bytes.
64 images did not require optimisation. |
…q/officelife into 2021-09-07-comments-to-tasks
asbiin
requested changes
Sep 10, 2021
app/Http/Controllers/Company/Company/Project/ProjectMessagesController.php
Outdated
Show resolved
Hide resolved
app/Http/Controllers/Company/Company/Project/ProjectMessagesController.php
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add comments to... anything. We just started with project messages.
We've added a Comment object that can be morphed with
commentable. We just need to add this association to other objects now to add comments to anything.Comments are a dedicated shared Vue class, so we can apply to anything we want.
The class takes a prop called
postUrl. It's not super elegant, but it allows us to pass an endpoint and the class knows how to submit, edit and delete a comment based on this URL.