Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add decision logs to project #332

Merged
merged 19 commits into from
Oct 26, 2020
Merged

feat: add decision logs to project #332

merged 19 commits into from
Oct 26, 2020

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Oct 25, 2020

image

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 31.5%, saving 3.37 KB.

Filename Before After Improvement Visual comparison
public/img/streamline-icon-factory-engineer-3@140x140.png 10.72 KB 7.34 KB -31.5% View diff

33 images did not require optimisation.

Copy link
Contributor

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment

app/Models/Company/ProjectDecision.php Show resolved Hide resolved
Copy link
Contributor

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can close #330

webpack.mix.js Outdated Show resolved Hide resolved
webpack.mix.js Outdated Show resolved Hide resolved
djaiss and others added 5 commits October 26, 2020 12:51
Co-authored-by: Alexis Saettler <alexis@saettler.org>
Co-authored-by: Alexis Saettler <alexis@saettler.org>
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 16 Code Smells

53.1% 53.1% Coverage
4.2% 4.2% Duplication

@djaiss djaiss merged commit c549fff into main Oct 26, 2020
@djaiss djaiss deleted the 2020-10-20-decision-logs branch October 26, 2020 19:45
'title' => $log->object->{'title'},
]);

// no break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djaiss you missed a break here, the value of the sentence will be overriden

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - will fix in another PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

🎉 This PR is included in version 0.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants