Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix all mutated props #335

Merged
14 commits merged into from
Oct 30, 2020
Merged

fix: fix all mutated props #335

14 commits merged into from
Oct 30, 2020

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Oct 26, 2020 •
edited

Remove all mutated props in Vue pages.

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from djaiss October 26, 2020 09:38
djaiss
djaiss requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of i18n strings have been changed, which is not right.

resources/js/Pages/Adminland/CompanyNews/Index.vue Outdated Show resolved Hide resolved
@asbiin asbiin requested a review from djaiss October 26, 2020 17:59
djaiss
djaiss reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested each ones of the view with our Cypress tests to see if something is broken? I don’t think it would fail, but still.

resources/js/Pages/Adminland/Expense/Partials/Categories.vue Show resolved Hide resolved
@asbiin asbiin added the auto-squash Auto-completes a PR when reviews and checks pass label Oct 30, 2020
@asbiin
Copy link
Contributor Author

asbiin commented Oct 30, 2020

100% Cypress tests OK!

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

No Coverage information No Coverage information
9.5% 9.5% Duplication

djaiss
djaiss reviewed Oct 30, 2020
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the code itself - I haven't run the tests or Cypress to see if it still works.

Good job!

One thing to validate though - see comment.

resources/js/Shared/Select.vue Show resolved Hide resolved
@asbiin asbiin requested a review from djaiss October 30, 2020 19:16
@ghost ghost merged commit 152b0df into main Oct 30, 2020
@ghost ghost deleted the 20201026-fix-mutating-props branch October 30, 2020 19:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

🎉 This PR is included in version 0.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss approved these changes

Assignees
No one assigned
Labels
auto-squash Auto-completes a PR when reviews and checks pass released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbiin @djaiss