Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an option to disable mail verification #353

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Oct 27, 2020

This adds a new MAIL_VERIFY environment variable to disable email verification (true by default = enabled).
Cypress tests will require MAIL_VERIFY=false

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin force-pushed the 20201027-mail-verify-option branch from 67f2797 to 754140f Compare October 29, 2020 22:42
@asbiin asbiin merged commit 7c504dd into main Oct 29, 2020
@asbiin asbiin deleted the 20201027-mail-verify-option branch October 29, 2020 22:47
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2020

🎉 This PR is included in version 0.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2021

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant