Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow employee to log time tracking on dashboard #402

Merged
merged 36 commits into from
Dec 29, 2020

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Nov 20, 2020

This PR lets employees record their time tracking entries on the dashboard.

image

Each time tracking entry is done against a task in a project. If there are no tasks or no projects, we can’t log time tracking.

For now, a timesheet can be submitted by the employee.

Remaining to do in another PRs:

  • Approve timesheet by manager or HR
  • Reject timesheet by manager or hR
  • Delete row in a timesheet (employee)
  • Display timesheet info on the project itself

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation - The documentation is almost done but i’ll finalize it in another PR.
  • Dummy data

@djaiss djaiss marked this pull request as draft November 20, 2020 00:31
@djaiss
Copy link
Member Author

djaiss commented Dec 18, 2020

Still working on this one. It’s huge.

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 28.9%, saving 2.69 KB.

Filename Before After Improvement Visual comparison
public/img/streamline-icon-building-site@140x140.png 9.31 KB 6.62 KB -28.9% View diff

38 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@djaiss djaiss changed the title feat: time tracking feat: allow employee to log time tracking on dashboard Dec 29, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 19 Code Smells

76.3% 76.3% Coverage
5.6% 5.6% Duplication

@djaiss djaiss marked this pull request as ready for review December 29, 2020 16:55
@djaiss djaiss merged commit 78037b9 into main Dec 29, 2020
@djaiss djaiss deleted the 2020-11-16-time-tracking branch December 29, 2020 16:58
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant