Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support sentry reporting #403

Merged
merged 8 commits into from
Dec 13, 2020
Merged

feat: support sentry reporting #403

merged 8 commits into from
Dec 13, 2020

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Nov 20, 2020 •
edited

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from djaiss November 21, 2020 19:56
djaiss
djaiss requested changes Nov 22, 2020
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I've added one super important comment.
Also, we should update the .env.example as well with default values --- shouldn't we?

app/Http/Middleware/SentryContext.php Outdated Show resolved Hide resolved
djaiss
djaiss approved these changes Dec 13, 2020
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@asbiin asbiin changed the title feat: add sentry feat: support sentry reporting Dec 13, 2020
@asbiin asbiin merged commit 16ec676 into main Dec 13, 2020
@asbiin asbiin deleted the 20201119-sentry branch December 13, 2020 12:28
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss approved these changes

Assignees
No one assigned
Labels
released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbiin @djaiss