Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: indicate if an employee status is external or internal #436

Merged
merged 7 commits into from
Dec 16, 2020

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Dec 13, 2020

This PR adds an "external" or "internal" state to employee statuses.

External employees will (in another PR) be associated a contract date, along with a rate. This will let us manage the contract renewals, and also be used to know how much the contractor charges.

This is the changes in the UI in Adminland:

employee_status_create

@djaiss djaiss changed the title feat: inidcate if an employee status is external or internal feat: indicate if an employee status is external or internal Dec 13, 2020
@djaiss djaiss marked this pull request as ready for review December 15, 2020 23:33
@djaiss djaiss requested a review from asbiin December 15, 2020 23:35
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@djaiss djaiss merged commit 3a88c67 into main Dec 16, 2020
@djaiss djaiss deleted the internal-external-employees branch December 16, 2020 14:38
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant