Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display timesheets on employee profile page #474

Merged
merged 12 commits into from
Jan 6, 2021

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Jan 5, 2021

This PR adds all the timesheets (rejected or approved) of an employee.

image

image

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2021

Images automagically compressed by Calibre's image-actions

Compression reduced images by 32.4%, saving 2.82 KB.

Filename Before After Improvement Visual comparison
public/img/streamline-icon-employee-planner-3@140x140.png 8.69 KB 5.87 KB -32.4% View diff

42 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@djaiss djaiss marked this pull request as ready for review January 6, 2021 22:05
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

73.9% 73.9% Coverage
2.6% 2.6% Duplication

@djaiss djaiss merged commit d9eb89c into main Jan 6, 2021
@djaiss djaiss deleted the 2021-01-04-history-timesheets-employee branch January 6, 2021 22:21
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.0-alpha.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant