Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HR dashboard for timesheets #512

Merged
merged 6 commits into from
Jan 25, 2021
Merged

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Jan 23, 2021

So, this PR adds a dashboard for HR for the timesheets specifically. On this screen, HR people get to accept or reject timesheets for employees who don’t have a manager.

It also fixes a bunch of bugs regarding timesheets.

Empty state:
image

Not empty state:
image

List:
image

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@djaiss djaiss requested a review from a team as a code owner January 23, 2021 14:53
@djaiss djaiss requested review from asbiin and removed request for a team January 23, 2021 14:53
@djaiss djaiss marked this pull request as draft January 23, 2021 14:55
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

100.0% 100.0% Coverage
23.3% 23.3% Duplication

@djaiss djaiss marked this pull request as ready for review January 23, 2021 20:50
@djaiss djaiss merged commit 6d21621 into main Jan 25, 2021
@djaiss djaiss deleted the 2021-01-19-hr-area-time-tracking branch January 25, 2021 22:55
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

🎉 This PR is included in version 0.1.0-alpha.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant