Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to escape find by clic #613

Merged
merged 1 commit into from
Mar 11, 2021
Merged

feat: allow to escape find by clic #613

merged 1 commit into from
Mar 11, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Mar 11, 2021

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@djaiss
Copy link
Member

djaiss commented Mar 11, 2021

Awesome.

@asbiin asbiin merged commit a25ef53 into main Mar 11, 2021
@asbiin asbiin deleted the 20210311-find-esc branch March 11, 2021 19:34
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbiin @djaiss