Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add files in a project #634

Merged
merged 10 commits into from
Mar 27, 2021
Merged

feat: add files in a project #634

merged 10 commits into from
Mar 27, 2021

Conversation

djaiss
Copy link
Member

@djaiss djaiss commented Mar 17, 2021

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 33.3%, saving 2.90 KB.

Filename Before After Improvement Visual comparison
public/img/streamline-icon-content-filter@140x140.png 8.70 KB 5.80 KB -33.3% View diff

48 images did not require optimisation.

Update required: Update image-actions configuration to the latest version before 1/1/21. See README for instructions.

@djaiss djaiss marked this pull request as ready for review March 27, 2021 01:19
@djaiss djaiss requested a review from a team as a code owner March 27, 2021 01:19
@djaiss djaiss requested review from asbiin and removed request for a team March 27, 2021 01:19
@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

78.4% 78.4% Coverage
1.4% 1.4% Duplication

@djaiss djaiss merged commit 9d0af98 into main Mar 27, 2021
@djaiss djaiss deleted the 2021-03-15-files-in-project branch March 27, 2021 01:24
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant