Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement laravel jetstream and fortify #671

Merged
merged 29 commits into from
May 30, 2021
Merged

feat: implement laravel jetstream and fortify #671

merged 29 commits into from
May 30, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Apr 3, 2021 •
edited

This implements Laravel Jestream and Fortify, which is a convenient way to have login, verify email, forgot password, 2fa, etc.

It adds a new page at /user/profile for user preferences

  • password change
  • activate 2fa
  • remove other sessions

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from a team as a code owner April 3, 2021 10:45
@asbiin asbiin requested review from djaiss and removed request for a team April 3, 2021 10:45
@asbiin asbiin changed the title feat: implement Laravel jetsream and Fortify feat: implement Laravel jetsream and fortify Apr 3, 2021
@asbiin asbiin marked this pull request as draft April 3, 2021 14:39
@asbiin asbiin changed the title feat: implement Laravel jetsream and fortify feat: implement Laravel jetstream and fortify Apr 9, 2021
@djaiss
Copy link
Member

djaiss commented Apr 15, 2021

@asbiin do we need this now?

@asbiin
Copy link
Contributor Author

asbiin commented Apr 15, 2021

@djaiss it improves scenarios for login/register/forgot password/verify email.
It also help implement 2 scenarios:

  • Change your password
  • Activate 2FA
    We need these 2 features.

@asbiin asbiin marked this pull request as ready for review April 20, 2021 21:40
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

96.0% 96.0% Coverage
0.0% 0.0% Duplication

@djaiss
Copy link
Member

djaiss commented May 30, 2021

Alright let's merge this.

@djaiss djaiss changed the title feat: implement Laravel jetstream and fortify feat: implement laravel jetstream and fortify May 30, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

95.8% 95.8% Coverage
0.0% 0.0% Duplication

@djaiss djaiss merged commit 6874b1e into main May 30, 2021
@djaiss djaiss deleted the 20210403-fortify-jetstream branch May 30, 2021 19:19
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbiin @djaiss