Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle errors in production #801

Merged
merged 3 commits into from
May 21, 2021
Merged

feat: handle errors in production #801

merged 3 commits into from
May 21, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Apr 19, 2021

Following inertia handbook: https://inertiajs.com/error-handling

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

84.2% 84.2% Coverage
0.0% 0.0% Duplication

@djaiss
Copy link
Member

djaiss commented Apr 19, 2021

Interesting.

@asbiin asbiin enabled auto-merge (squash) May 21, 2021 21:34
@asbiin asbiin merged commit c060b00 into main May 21, 2021
@asbiin asbiin deleted the 20210418-inertia-error branch May 21, 2021 21:37
@sonarcloud
Copy link

sonarcloud bot commented May 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

84.2% 84.2% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.1.0-alpha.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants