Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skip home if employee has 1 company #963

Merged
merged 1 commit into from
Jun 5, 2021
Merged

feat: skip home if employee has 1 company #963

merged 1 commit into from
Jun 5, 2021

Conversation

asbiin
Copy link
Contributor

@asbiin asbiin commented Jun 5, 2021

You fool, don't forget these steps:

  • Unit tests
  • Tests with Cypress
  • Documentation
  • Dummy data

@asbiin asbiin requested a review from a team as a code owner June 5, 2021 06:34
@asbiin asbiin requested review from djaiss and removed request for a team June 5, 2021 06:34
@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

djaiss
djaiss approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@djaiss djaiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix for now. We'll need to improve this later.

@asbiin asbiin merged commit 552c460 into main Jun 5, 2021
@asbiin asbiin deleted the 20210605-skip-home branch June 5, 2021 17:24
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djaiss djaiss djaiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbiin @djaiss