Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garage limit garaging and state preservation at hq #2107

Conversation

HakonRydland
Copy link
Collaborator

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
as per dev meeting 28.Aug 2021:
- Garaging has been limited to locations with flags present, these are: Outposts, Seaports, Airports/Bases, Resources, and Factories
- Vehicles left near HQ will maintain their state on save/load.

Please specify which Issue this PR Resolves.

closes #2091 #2029 #605

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:

  1. get a vehicle, damage it, save with vehicle at HQ, reload. vehicle should be restored with the state preserved.
  2. try to garage anywhere but at one of the aforementioned locations.

Notes:

@HakonRydland HakonRydland added Change A change to existing functionality Balance For issues and PRs regarding game balance. Exploit Issue/PR that addresses an exploit. labels Aug 29, 2021
@HakonRydland HakonRydland added this to the 2.5.3 milestone Aug 29, 2021
Copy link

@Lazejun Lazejun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuel, Ammo and Damage of Vehicles near HQ gets saved.

Garaging is limited to HQ, Outposts, Factories, Seaports, Resources, Airports.

should work as expected 👍

@Bob-Murphy
Copy link

Both open points resolved?
Ready to merge?

@HakonRydland
Copy link
Collaborator Author

Both open points resolved?
Ready to merge?

now both are resolved

@jaj22
Copy link

jaj22 commented Sep 5, 2021

Yeah, I thought I had a PR I needed to approve but I couldn't find it.

@Bob-Murphy Bob-Murphy merged commit 6bb473a into official-antistasi-community:unstable Sep 14, 2021
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Oct 8, 2021
@HakonRydland HakonRydland deleted the garage-limit-garaging-and-state-preservation-at-hq branch February 15, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Balance For issues and PRs regarding game balance. Change A change to existing functionality Exploit Issue/PR that addresses an exploit. Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Vehicle state restore exploit on HQ
4 participants