Magazines getter #2114
Merged
Magazines getter #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there not standard places to look for subclass magazines to speed up the deep search? I'm thinking muzzles for weapons, probably turrets for vehicles? |
|
Good thought, ill look into if its consistent across mods and covers all magazines Assuming adhering to format for arma internals to function i suspect it would, but the 3cb vehicles are snowflakes |
|
yea, got it to have the deep parse result for under 0.1ms consistently |
jaj22
approved these changes
Sep 5, 2021
|
Looks like we do have a good short-term use for this. See #2074. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Information: recent comments and experience has shown a lack of complete compatible magazine info, as well as the complexity of getting this information.
as how compatible magazines can be included in a weapon or vehicle config this requires a bit of brute force.
therefore the default behavior is to do a full config search, but as this can be some what slow (example numbers bellow) i also added a the option to perform a shallow search.
This checks both magazines and magazineWells
Test output
{ "arifle_MX_GL_F_shallow": { "class": "arifle_MX_GL_F", "time-ms": 0.0464, "Shallow": true, "Output": [ "30Rnd_65x39_caseless_mag", "30Rnd_65x39_caseless_khaki_mag", "30Rnd_65x39_caseless_black_mag", "30Rnd_65x39_caseless_mag_Tracer", "30Rnd_65x39_caseless_khaki_mag_Tracer", "30Rnd_65x39_caseless_black_mag_Tracer", "ACE_30Rnd_65x39_caseless_mag_Tracer_Dim", "ACE_30Rnd_65x47_Scenar_mag", "ACE_30Rnd_65_Creedmor_mag", "100Rnd_65x39_caseless_mag", "100Rnd_65x39_caseless_khaki_mag", "100Rnd_65x39_caseless_black_mag", "100Rnd_65x39_caseless_mag_tracer", "100Rnd_65x39_caseless_khaki_mag_tracer", "100Rnd_65x39_caseless_black_mag_tracer", "ACE_100Rnd_65x39_caseless_mag_Tracer_Dim", "100Rnd_65x39_caseless_mag_Tracer", "100Rnd_65x39_caseless_khaki_mag_Tracer", "100Rnd_65x39_caseless_black_mag_Tracer" ] }, "arifle_MX_GL_F": { "class": "arifle_MX_GL_F", "time-ms": 1.25, "Shallow": false, "Output": [ "30Rnd_65x39_caseless_mag", "1Rnd_HE_Grenade_shell", "UGL_FlareWhite_F", "UGL_FlareGreen_F", "UGL_FlareRed_F", "UGL_FlareYellow_F", "UGL_FlareCIR_F", "1Rnd_Smoke_Grenade_shell", "1Rnd_SmokeRed_Grenade_shell", "1Rnd_SmokeGreen_Grenade_shell", "1Rnd_SmokeYellow_Grenade_shell", "1Rnd_SmokePurple_Grenade_shell", "1Rnd_SmokeBlue_Grenade_shell", "1Rnd_SmokeOrange_Grenade_shell", "3Rnd_HE_Grenade_shell", "3Rnd_UGL_FlareWhite_F", "3Rnd_UGL_FlareGreen_F", "3Rnd_UGL_FlareRed_F", "3Rnd_UGL_FlareYellow_F", "3Rnd_UGL_FlareCIR_F", "3Rnd_Smoke_Grenade_shell", "3Rnd_SmokeRed_Grenade_shell", "3Rnd_SmokeGreen_Grenade_shell", "3Rnd_SmokeYellow_Grenade_shell", "3Rnd_SmokePurple_Grenade_shell", "3Rnd_SmokeBlue_Grenade_shell", "3Rnd_SmokeOrange_Grenade_shell", "ACE_HuntIR_M203", "30Rnd_65x39_caseless_khaki_mag", "30Rnd_65x39_caseless_black_mag", "30Rnd_65x39_caseless_mag_Tracer", "30Rnd_65x39_caseless_khaki_mag_Tracer", "30Rnd_65x39_caseless_black_mag_Tracer", "ACE_30Rnd_65x39_caseless_mag_Tracer_Dim", "ACE_30Rnd_65x47_Scenar_mag", "ACE_30Rnd_65_Creedmor_mag", "100Rnd_65x39_caseless_mag", "100Rnd_65x39_caseless_khaki_mag", "100Rnd_65x39_caseless_black_mag", "100Rnd_65x39_caseless_mag_tracer", "100Rnd_65x39_caseless_khaki_mag_tracer", "100Rnd_65x39_caseless_black_mag_tracer", "ACE_100Rnd_65x39_caseless_mag_Tracer_Dim", "100Rnd_65x39_caseless_mag_Tracer", "100Rnd_65x39_caseless_khaki_mag_Tracer", "100Rnd_65x39_caseless_black_mag_Tracer", "rhs_mag_M441_HE", "rhs_mag_M433_HEDP", "rhs_mag_M397_HET", "rhs_mag_m576", "rhs_mag_M4009", "rhs_mag_M583A1_white", "rhs_mag_M585_white", "rhs_mag_M661_green", "rhs_mag_M662_red", "rhs_mag_M585_white_cluster", "rhs_mag_M663_green_cluster", "rhs_mag_M664_red_cluster", "rhs_mag_M713_red", "rhs_mag_M714_white", "rhs_mag_M715_green", "rhs_mag_M716_yellow", "rhs_mag_M781_Practice", "ACE_40mm_flare_white", "ACE_40mm_flare_red", "ACE_40mm_flare_green", "ACE_40mm_flare_ir" ] }, "B_MBT_01_base_F_shallow" : { "class": "B_MBT_01_base_F", "time-ms": 0.011, "Shallow": true, "Output": [] }, "B_MBT_01_base_F": { "class": "B_MBT_01_base_F", "time-ms": 4.82, "Shallow": true, "Output": [ "24Rnd_120mm_APFSDS_shells_Tracer_Red", "12Rnd_120mm_HE_shells_Tracer_Red", "12Rnd_120mm_HEAT_MP_T_Red", "200Rnd_762x51_Belt_Red", "SmokeLauncherMag" ] } }Please specify which Issue this PR Resolves.
closes #XXXX
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes: i plan on having this be used for compatible magazine checking for the arsenal and maybe other things as well