Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lamp drop action after respawn and some related things #2157

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Oct 1, 2021

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

  • Fix bug where drop object action (for dropping lamps) wasn't added to player after respawn.
  • Fix bug where actions were left on a dead player object.
  • Fix bug where LTC actions could be added when disabled by params.

Also accidentally added the setOvercast functionality that solidifies the rain-removal tent option. Can't be bothered to unfuck git and separate it. Note that the overcast state changes very slowly, but it should prevent the rain from coming back.

Please specify which Issue this PR Resolves.

closes #2154
closes #1992

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added Bug-fix Change A change to existing functionality labels Oct 1, 2021
@jaj22 jaj22 added this to the 2.5.3 milestone Oct 1, 2021
Copy link

@killerswin2 killerswin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Bob-Murphy Bob-Murphy merged commit 0583aeb into official-antistasi-community:unstable Oct 2, 2021
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Change A change to existing functionality Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: After picking up a lamp object, there is no drop action Use of SetOvercast to remove Clouds
3 participants