Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Rework Assets and Feature Toggle #2229

Merged
merged 5 commits into from Feb 13, 2022
Merged

UI Rework Assets and Feature Toggle #2229

merged 5 commits into from Feb 13, 2022

Conversation

CalebSerafin
Copy link
Member

What type of PR is this.

  • Bug
  • Change
  • Enhancement

What have you changed and why?

  • Added Assets for UI Rework
  • Added Defines for GUI
  • Added Feature Toggle around GUI calls.
  • Fixed syntax error for Music button in Game Options.

Please verify the following and ensure all checks are completed.

  • Have you loaded the mission in LAN host?
  • Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  • No
  • Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
Load antistasi
Game Options > Music [On/Off] > Enjoy.
Try all the menus you find.

@CalebSerafin CalebSerafin added Bug-fix Enhancement New feature or request labels Jan 26, 2022
@CalebSerafin CalebSerafin added this to the 2.5.X milestone Jan 26, 2022
@HakonRydland
Copy link
Collaborator

addon base and feature toggle looks good, as for the UI functionality, cursory glance looks good but will require a lot more time to review properly

Copy link

@Lazejun Lazejun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt catch fire, Music button works

@Bob-Murphy Bob-Murphy merged commit 053c476 into unstable Feb 13, 2022
@Bob-Murphy Bob-Murphy deleted the CS-UI-Rework branch February 16, 2022 20:00
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Enhancement New feature or request Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants