Added additional Punishment logging for cheking player's UAV body #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebSerafin
added
Enhancement
HakonRydland
approved these changes
Apr 23, 2022
Bob-Murphy
pushed a commit
that referenced
this pull request
Apr 24, 2022
* [CIVILIAN] Temp fix for Resource Civ's. * Added additional Punishment logging for cheking player's UAV body (#2339) ## What type of PR is this. * Bug * Change * [x] Enhancement * [x] Logging ### What have you changed and why? * Refactored `A3A_fnc_punishment_FF` to `A3A_fnc_punishment_evaluateEvent` * Added additional Punishment logging for cheking player's UAV body. ### Please verify the following and ensure all checks are completed. 1. [x] Have you loaded the mission in LAN host? 2. [ ] Have you loaded the mission on a dedicated server? ### Is further testing or are further changes required? * [x] No * Yes (Please provide further detail below.) ### How can the changes be tested? Steps: ```sqf [player, 0, 0, objNull] remoteExec ["A3A_fnc_punishment_evaluateEvent",2]; // Test self with no victim [player, 0, 0, cursorObject] remoteExec ["A3A_fnc_punishment_evaluateEvent",2]; // Test self with victim [getPlayerUID player,"forgive"] remoteExec ["A3A_fnc_punishment_release",2]; // Self forgive all sins ``` Notes: * Refactored punishment_FF to ..._evaluateEvent. * Added Additional Logging. * Check to see if original body matches instigator. * Logs that UAV was detected in FF case. * Added a block in confimPlacement if already placing (#2340) ### What have you changed and why? Information: Added a block to prevent multiple event handlers being added and therefore not be able to remove them all on cleanup Notes: * Added a block in confimPlacement if already placing, this should prevent multi added event handlers * review cange requests * review cange requests 2 * review cange requests 3 * [PATCOM] First Pass Artillery. Needs work. * added and using randomSelection of specOps (#2329) What have you changed and why? Information: added groupSpecOpsRandom, and groupSpecOpsSniper. groupSpecOpsRandom is used for random selection of 6 man group of sf units. groupSpecOpsSniper will be used for sniper patrols, right now It is not used, just defines it. groupSpecOps still exist, was kept for no school specOps if needed somewhere later. all references of groupSpecOps are replaced with groupSpecOpsRandom. (hq_attack, dead towns, and controls) * [PATCOM] Additional Artillery Handling * Debug * Added debug to clean up RPT Co-authored-by: Caleb Serafin <calebserafin@outlook.com> Co-authored-by: HakonRydland <61709767+HakonRydland@users.noreply.github.com> Co-authored-by: Ellis Nielsen <thecakebecamethelie@yahoo.com>
Bob-Murphy
pushed a commit
that referenced
this pull request
Apr 25, 2022
* [CIVILIAN] Temp fix for Resource Civ's. * Added additional Punishment logging for cheking player's UAV body (#2339) ## What type of PR is this. * Bug * Change * [x] Enhancement * [x] Logging ### What have you changed and why? * Refactored `A3A_fnc_punishment_FF` to `A3A_fnc_punishment_evaluateEvent` * Added additional Punishment logging for cheking player's UAV body. ### Please verify the following and ensure all checks are completed. 1. [x] Have you loaded the mission in LAN host? 2. [ ] Have you loaded the mission on a dedicated server? ### Is further testing or are further changes required? * [x] No * Yes (Please provide further detail below.) ### How can the changes be tested? Steps: ```sqf [player, 0, 0, objNull] remoteExec ["A3A_fnc_punishment_evaluateEvent",2]; // Test self with no victim [player, 0, 0, cursorObject] remoteExec ["A3A_fnc_punishment_evaluateEvent",2]; // Test self with victim [getPlayerUID player,"forgive"] remoteExec ["A3A_fnc_punishment_release",2]; // Self forgive all sins ``` Notes: * Refactored punishment_FF to ..._evaluateEvent. * Added Additional Logging. * Check to see if original body matches instigator. * Logs that UAV was detected in FF case. * Added a block in confimPlacement if already placing (#2340) ### What have you changed and why? Information: Added a block to prevent multiple event handlers being added and therefore not be able to remove them all on cleanup Notes: * Added a block in confimPlacement if already placing, this should prevent multi added event handlers * review cange requests * review cange requests 2 * review cange requests 3 * [PATCOM] First Pass Artillery. Needs work. * added and using randomSelection of specOps (#2329) What have you changed and why? Information: added groupSpecOpsRandom, and groupSpecOpsSniper. groupSpecOpsRandom is used for random selection of 6 man group of sf units. groupSpecOpsSniper will be used for sniper patrols, right now It is not used, just defines it. groupSpecOps still exist, was kept for no school specOps if needed somewhere later. all references of groupSpecOps are replaced with groupSpecOpsRandom. (hq_attack, dead towns, and controls) * [PATCOM] Additional Artillery Handling * Debug * Added debug to clean up RPT * Minor Balance Pass * Reset Sleep to Default Times. Co-authored-by: Caleb Serafin <calebserafin@outlook.com> Co-authored-by: HakonRydland <61709767+HakonRydland@users.noreply.github.com> Co-authored-by: Ellis Nielsen <thecakebecamethelie@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
A3A_fnc_punishment_FFtoA3A_fnc_punishment_evaluateEventPlease verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps: