Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player and Rebel Faction starting money parameters #2503

Merged
merged 2 commits into from Oct 31, 2022
Merged

Player and Rebel Faction starting money parameters #2503

merged 2 commits into from Oct 31, 2022

Conversation

igorkis-scrts
Copy link

@igorkis-scrts igorkis-scrts commented Oct 27, 2022 •
edited

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
PR gives ability to tune starting money for individual players and overall rebel at startup params menu.

image

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:

  1. Choose any starting money dropdown value.
  2. Start new game.
  3. Check if custom starting money parameter have applied.

Notes:

@igorkis-scrts
💲Money params
ffc59b7 
* Player starting money parameter
* Rebel faction starting money
@igorkis-scrts
more verbose variable name
216cbfd
killerswin2
killerswin2 approved these changes Oct 27, 2022
View reviewed changes
Copy link

@killerswin2 killerswin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good.

@Bob-Murphy Bob-Murphy added this to the 3.0 milestone Oct 29, 2022
@Bob-Murphy
Copy link

That's a simple thing, should be fine within 3.0

@Bob-Murphy Bob-Murphy modified the milestones: 3.0, 3.1 Oct 30, 2022
@jaj22
Copy link

jaj22 commented Oct 31, 2022

@Bob-Murphy Best to speed-merge for 3.0 because it's trivial and params is an eternal merge conflict zone. Looks like I need to add a param for the AFK timer.

@Bob-Murphy Bob-Murphy modified the milestones: 3.1, 3.0 Oct 31, 2022
@Bob-Murphy Bob-Murphy added Enhancement New feature or request Ready for merge labels Oct 31, 2022
@Bob-Murphy Bob-Murphy merged commit d4bb7ce into official-antistasi-community:unstable Oct 31, 2022
@igorkis-scrts igorkis-scrts deleted the feature/player-starting-money-params branch November 21, 2022 13:43
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Dec 1, 2022
igorkis-scrts added a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
@igorkis-scrts
Player and Rebel Faction starting money parameters (official-antistas…
f67867c 
…i-community#2503)

* 💲Money params

* Player starting money parameter
* Rebel faction starting money

* more verbose variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaj22 jaj22 jaj22 approved these changes

@killerswin2 killerswin2 killerswin2 approved these changes

Assignees
No one assigned
Labels
Added to changelog Added to changelog Enhancement New feature or request Ready for merge
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@igorkis-scrts @Bob-Murphy @jaj22 @killerswin2