Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AFK timeout parameter + status bar indicator and logging tweaks #2521

Merged
merged 1 commit into from Nov 4, 2022
Merged

AFK timeout parameter + status bar indicator and logging tweaks #2521

merged 1 commit into from Nov 4, 2022

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Nov 2, 2022

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

  • Made the AFK checker timeout a parameter. 15 minutes probably makes more sense for community servers, but short values are best for SP alt-tabbing.
  • Added a red AFK indicator at the end of the status bar.
  • Fixed cases where commander switch logging was using the unit rather than the unit name.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22
AFK checker timeout param, status and logging tweaks:
1caeffa 
- Add parameter for AFK timeout.
- Show AFK status on the client info bar.
- Fix cases where commander logging was using the unit rather than the name.
@jaj22 jaj22 added the Enhancement New feature or request label Nov 2, 2022
@Bob-Murphy Bob-Murphy added this to the 3.0 milestone Nov 4, 2022
killerswin2
killerswin2 approved these changes Nov 4, 2022
View reviewed changes
Copy link

@killerswin2 killerswin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Bob-Murphy Bob-Murphy merged commit 9b277db into official-antistasi-community:unstable Nov 4, 2022
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Dec 1, 2022
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
@Bob-Murphy
Merge pull request official-antistasi-community#2521 from jaj22/afk-t…
9868925 
…imeout-param

AFK timeout parameter + status bar indicator and logging tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killerswin2 killerswin2 killerswin2 approved these changes

Assignees
No one assigned
Labels
Added to changelog Added to changelog Enhancement New feature or request Ready for merge
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaj22 @killerswin2 @Bob-Murphy