Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance utility trucks in cases where the civ factions lacks them #2532

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Nov 6, 2022

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

One of the main complaints about the Unsung modset was that it was much harder to acquire fuel and repair trucks due to the lack of civilian vehicles. This PR attempts to balance that out by adding a chance of picking military fuel and repair vehicles instead of the static cargo trucks at bases. It's exploitable by spawn/despawn but no more so than the civ spawns in other modsets.

Also clears up some old/broken occupant/invader asymmetry on usage of cargo trucks.

Note that createAIOutposts is also used for seaports, and createAIResources is also used for factories. Airports already have a chance of spawning utility trucks so I didn't touch those.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

I think the only current civ faction without fuel/repair vehicles is Unsung, although you can test like this with other factions:

A3A_faction_civ set ["vehiclesCivRepair", []];
A3A_faction_civ set ["vehiclesCivFuel", []];

@jaj22 jaj22 added the Change A change to existing functionality label Nov 6, 2022
Copy link

@Lazejun Lazejun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@Bob-Murphy Bob-Murphy added this to the 3.0 milestone Nov 8, 2022
@Bob-Murphy Bob-Murphy merged commit 6cb7cd5 into official-antistasi-community:unstable Nov 8, 2022
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Dec 1, 2022
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
…ce-utility-trucks

Balance utility trucks in cases where the civ factions lacks them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Change A change to existing functionality Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants