Balance utility trucks in cases where the civ factions lacks them #2532
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
One of the main complaints about the Unsung modset was that it was much harder to acquire fuel and repair trucks due to the lack of civilian vehicles. This PR attempts to balance that out by adding a chance of picking military fuel and repair vehicles instead of the static cargo trucks at bases. It's exploitable by spawn/despawn but no more so than the civ spawns in other modsets.
Also clears up some old/broken occupant/invader asymmetry on usage of cargo trucks.
Note that createAIOutposts is also used for seaports, and createAIResources is also used for factories. Airports already have a chance of spawning utility trucks so I didn't touch those.
Please specify which Issue this PR Resolves.
closes #XXXX
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
I think the only current civ faction without fuel/repair vehicles is Unsung, although you can test like this with other factions: