Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gm templates Winter #2601

Merged
merged 12 commits into from Apr 1, 2023
Merged

Gm templates Winter #2601

merged 12 commits into from Apr 1, 2023

Conversation

targetingsnake
Copy link

@targetingsnake targetingsnake commented Dec 30, 2022 •
edited

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Added winter template for GM, maybe desert will follow here soon

Please specify which Issue this PR Resolves.

none

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:

  1. Build mod
  2. load with mods for GM
  3. test winter template

Notes:

@targetingsnake targetingsnake marked this pull request as draft December 30, 2022 15:51
@targetingsnake
Copy link
Author

Desert Camo will be added soon, put this already up so winter stuff can be reviewed

@Lazejun Lazejun self-requested a review January 8, 2023 12:31
@Lazejun Lazejun added this to the 3.1 milestone Jan 8, 2023
@Lazejun Lazejun added Change A change to existing functionality Enhancement New feature or request labels Jan 8, 2023
@Bob-Murphy Bob-Murphy modified the milestones: 3.1, 3.2 Jan 9, 2023
@targetingsnake targetingsnake mentioned this pull request Mar 28, 2023
Closed
7 tasks
@targetingsnake
Copy link
Author

desert camo will be delayed till 3.3 or so

@Bob-Murphy
Copy link

Bob-Murphy commented Mar 28, 2023 •
edited

Please take out the desert template.
Clean merges are prefered.

@Bob-Murphy
Copy link

Also, once done please adapt the title and the description accordingly.
Thank you

@targetingsnake targetingsnake added Templates Items related to templates and removed Draft labels Mar 28, 2023
@targetingsnake targetingsnake changed the title Gm templates other Gm templates Winter Mar 28, 2023
@targetingsnake
Copy link
Author

@Bob-Murphy done

@Bob-Murphy Bob-Murphy marked this pull request as ready for review March 28, 2023 14:05
killerswin2
killerswin2 approved these changes Apr 1, 2023
View reviewed changes
Copy link

@killerswin2 killerswin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for merge and testing.

@Bob-Murphy Bob-Murphy added Change requested A change has been requested, and this can't be merged until it's done. and removed Ready for merge labels Apr 1, 2023
@Bob-Murphy
Copy link

btw, changed Winter to Arctic to have it matching the other stuff we have

Lazejun
Lazejun approved these changes Apr 1, 2023
View reviewed changes
Copy link

@Lazejun Lazejun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now

@Bob-Murphy Bob-Murphy added Ready for merge and removed Change requested A change has been requested, and this can't be merged until it's done. labels Apr 1, 2023
@Bob-Murphy Bob-Murphy merged commit 35cad55 into unstable Apr 1, 2023
@Bob-Murphy Bob-Murphy deleted the GM-Templates-other branch April 5, 2023 21:18
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label May 8, 2023
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
@targetingsnake @Bob-Murphy
Gm templates Winter (official-antistasi-community#2601)
1e95622 
* started BW-Templates arctic

* started nva winter template (currently copy of existing one)

* added swaped stuff in nva template; corrected artillery part in bw arctiv template

* finished winter

* fixed errors

* updated GM-Vehicle-Attributes

* added BW desert Camo

* commented BW Desert template out

* changed east german helmets

* cleaned up

* removed unused configs

* Laze Feedback

---------

Co-authored-by: targetingsnake <targetingsnake@users.noreply.github.com>
Co-authored-by: Bob-Murphy <Bob-Murphy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bob-Murphy Bob-Murphy Bob-Murphy left review comments

@killerswin2 killerswin2 killerswin2 approved these changes

@Lazejun Lazejun Lazejun approved these changes

@jaj22 jaj22 Awaiting requested review from jaj22

Assignees

@CalebSerafin CalebSerafin

@Bob-Murphy Bob-Murphy

Labels
Added to changelog Added to changelog Change A change to existing functionality Enhancement New feature or request Ready for merge Templates Items related to templates
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@targetingsnake @Bob-Murphy @killerswin2 @Lazejun @CalebSerafin