Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix early battle menu key use #2618

Merged
merged 1 commit into from Jan 8, 2023
Merged

Fix early battle menu key use #2618

merged 1 commit into from Jan 8, 2023

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Jan 8, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

With the setup UI, I overlooked the ability to use various Antistasi hotkeys before associated systems were initialized, causing errors with uninitialized data. This PR disables those hotkeys until client init is complete.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added the Bug-fix label Jan 8, 2023
@jaj22 jaj22 added this to the 3.1 milestone Jan 8, 2023
Lazejun
Lazejun approved these changes Jan 8, 2023
View reviewed changes
Copy link

@Lazejun Lazejun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this Prevents opening the Battle Menu before you start the Game.

@Bob-Murphy Bob-Murphy merged commit 85aeb1e into official-antistasi-community:unstable Jan 8, 2023
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
@Bob-Murphy
Merge pull request official-antistasi-community#2618 from jaj22/fix-e…
b3125f0 
…arly-key-use

Fix early battle menu key use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lazejun Lazejun Lazejun approved these changes

@HakonRydland HakonRydland HakonRydland approved these changes

@CalebSerafin CalebSerafin Awaiting requested review from CalebSerafin

@killerswin2 killerswin2 Awaiting requested review from killerswin2

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaj22 @Lazejun @HakonRydland @Bob-Murphy