minor resourcecheck old code cleanup #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were there any functional changes in civInit aside from the postMortem call? |
|
Nope, it's just a light refactoring of that particular function + postmortem call. |
jaj22
reviewed
Jan 29, 2023
jaj22
approved these changes
Jan 29, 2023
|
@igorkis-scrts merge conflicts |
…eanup # Conflicts: # A3A/addons/core/functions/CREATE/fn_CIVinit.sqf
|
@Bob-Murphy |
igorkis-scrts
added a commit
to igorkis-scrts/A3-Antistasi-Plus
that referenced
this pull request
Aug 8, 2023
* minor resourcecheck old code cleanup * getPosAtl, switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Information:
Seems to be that
fn_resourcecheckuses leftover Barbolani's code that no longer exists/used anymore (statusActnowhere to be found in the current state of codebase) - seems that at some point there were armed CIVILIAN-side, uh, civilians, that required special cleanup on each resource tick.So, this PR replaces this code with simple post-mortem call which is used everywhere in same cases. Also, it will make resource tick a little bit faster under certain circumstances as it will no longer iterate through
allUnits.Please specify which Issue this PR Resolves.
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?