Improved setup process feedback hints #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bob-Murphy
approved these changes
Jan 22, 2023
Bob-Murphy
changed the title
Bob-Murphy
added a commit
that referenced
this pull request
Jan 22, 2023
Improved setup process feedback hints (#2640)
igorkis-scrts
pushed a commit
to igorkis-scrts/A3-Antistasi-Plus
that referenced
this pull request
Aug 8, 2023
igorkis-scrts
pushed a commit
to igorkis-scrts/A3-Antistasi-Plus
that referenced
this pull request
Aug 8, 2023
…tistasi-community/unstable Improved setup process feedback hints (official-antistasi-community#2640)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
The setup feedback hints didn't make it clear that the server admin needed to log in, and weren't persistent, so it wasn't clear what stage the server startup process was at when it took more than ten seconds. This PR attempts to improve the feedback by moving it to a client-side update routine responding to a server-pushed status variable.
Hopefully reduces the need to provide support and makes it easier when necessary.
Please specify which Issue this PR Resolves.
closes #XXXX
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
Some of the new stringtable messages are untranslated.