Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS SAF Template/support #2662

Merged
merged 18 commits into from Mar 26, 2023
Merged

RHS SAF Template/support #2662

merged 18 commits into from Mar 26, 2023

Conversation

baldtune
Copy link

@baldtune baldtune commented Mar 2, 2023

Added template file and callout for it.

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
Added template file and callout for RHS:SAF support.

Please specify which Issue this PR Resolves.

some old idea/this has been requested by others.

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:
Load game and choose RHS SAF


Notes:
Let me know if anything needs change. I tried real life accuracy.

Added template file and callout for it.
@Bob-Murphy Bob-Murphy requested a review from Lazejun March 2, 2023 23:53
@Bob-Murphy Bob-Murphy added Enhancement New feature or request Templates Items related to templates labels Mar 2, 2023
@Bob-Murphy Bob-Murphy added this to the 3.2 milestone Mar 2, 2023
A3A/addons/core/Templates/Templates.hpp Outdated Show resolved Hide resolved
A3A/addons/core/Templates/Templates.hpp Outdated Show resolved Hide resolved
A3A/addons/core/Templates/Templates.hpp Outdated Show resolved Hide resolved
baldtune and others added 7 commits March 4, 2023 13:53
- Removed typos
- Correcting m21a_pbg40 ammos
- AA/AT backpack change
- Removed weapon loadout infso, as they were just reminder.
- Added another AA jet.
- Changed transport plane to c130J.
- Moved BTR's to light apc. BMP's to apc.
- Moved Mi17Sh to lightattack helis.
Added RHS_Saf_Base to require addon. changed name and filename, flagtexture update
Added RHS:SAF AA planes loadout. Both using same atm.
@baldtune baldtune requested a review from Lazejun March 4, 2023 13:24
Moved l18 to cas plane and updated loadout, cap version still AA plane
A3A/addons/core/Templates/Templates.hpp Outdated Show resolved Hide resolved
A3A/addons/core/Templates/Templates/RHS/RHS_AI_SAF.sqf Outdated Show resolved Hide resolved
A3A/addons/core/functions/Base/fn_setPlaneLoadout.sqf Outdated Show resolved Hide resolved
@baldtune baldtune requested review from rautamiekka and Lazejun and removed request for rautamiekka March 4, 2023 23:14
Only air to air missiles available.
@baldtune baldtune requested a review from Lazejun March 5, 2023 15:00
@Lazejun Lazejun added the Change requested A change has been requested, and this can't be merged until it's done. label Mar 6, 2023
Copy link

@Lazejun Lazejun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine now.

@Lazejun Lazejun added Ready for merge and removed Change requested A change has been requested, and this can't be merged until it's done. labels Mar 26, 2023
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bob-Murphy Bob-Murphy merged commit fe7878d into official-antistasi-community:unstable Mar 26, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label May 8, 2023
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
* RHS SAF Template

Added template file and callout for it.

* Flag change

* fixes

- Removed typos
- Correcting m21a_pbg40 ammos
- AA/AT backpack change
- Removed weapon loadout infso, as they were just reminder.

* Changes.

- Added another AA jet.
- Changed transport plane to c130J.
- Moved BTR's to light apc. BMP's to apc.
- Moved Mi17Sh to lightattack helis.

* Changed voices

* Rename RHS_AI_SAF_Temperate.sqf to RHS_AI_SAF.sqf

* Fixes

Added RHS_Saf_Base to require addon. changed name and filename, flagtexture update

* Update fn_setPlaneLoadout.sqf

Added RHS:SAF AA planes loadout. Both using same atm.

* Update fn_setPlaneLoadout.sqf

Moved l18 to cas plane and updated loadout, cap version still AA plane

* Update Templates.hpp

* Update Templates.hpp

* Added guns for SAF: L18 cas

* Moved L18 from AA to CAS

* militia vest changes

* Update fn_setPlaneLoadout.sqf

* Removed L18 CAS missile launcher

Only air to air missiles available.

* Update

---------

Co-authored-by: baldtune <baldtune@gmail.com>
Co-authored-by: Lazejun <57111907+Lazejun@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Enhancement New feature or request Ready for merge Templates Items related to templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants