init spawn places rewrite #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killerswin2
force-pushed
the
fn_initSpawnplaces_rewrite
branch
from
3ed6eed
to
382e67e
Compare
jaj22
approved these changes
Mar 20, 2023
| { | ||
| Error_1("InitSpawnPlaces: Marker %1 is not long enough for vehicles, required are 10 meters!", _x); | ||
| } | ||
| else | ||
| { | ||
| //Cleaning area | ||
| private _radius = sqrt (_length * _length + _width * _width); | ||
| private _radius = [0,0] vectorDistance [_width, _height]; |
There was a problem hiding this comment.
Could just do vectorMagnitude [_width, _height].
| _realLength = _vehicleCount * 4; | ||
| _realSpace = (_length - _realLength) / (_vehicleCount + 1); | ||
| _realSpace = (_width - _realLength) / (_vehicleCount + 1); |
There was a problem hiding this comment.
What this does is increase the spacing between vehicles if there's some extra space left over in the marker. This is a bad idea. If the spacing is variable and in some cases not enough, then we're gonna have occasional spawn explosions that are difficult to pin down. Better to keep the spacing consistent and adjust until it doesn't blow things up.
igorkis-scrts
pushed a commit
to igorkis-scrts/A3-Antistasi-Plus
that referenced
this pull request
Aug 8, 2023
* removed nasty distance * fixed wrong variables * renamed width to height, because arma is dumb * fixed height * change for bob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Information:
fixes the wrong variable being checked
Please specify which Issue this PR Resolves.
closes #2667
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes: