Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge case in minefields mine count #2671

Merged
merged 1 commit into from Mar 22, 2023
Merged

Fix edge case in minefields mine count #2671

merged 1 commit into from Mar 22, 2023

Conversation

killerswin2
Copy link

@killerswin2 killerswin2 commented Mar 17, 2023 •
edited

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
checks that the count is not equal to -1 before exit

Please specify which Issue this PR Resolves.

closes #2540

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:

Notes:

@killerswin2 killerswin2 changed the base branch from master to unstable March 17, 2023 02:02
Lazejun
Lazejun approved these changes Mar 17, 2023
View reviewed changes
Copy link

@Lazejun Lazejun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

In general I haven't bothered to do this as we wanted to rewrite the function at some point, in it's current state it's not that great.

@killerswin2
Copy link
Author

Yeah, just a temp measure.

Bob-Murphy
Bob-Murphy approved these changes Mar 22, 2023
View reviewed changes
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Bob-Murphy Bob-Murphy added this to the 3.2 milestone Mar 22, 2023
@Bob-Murphy Bob-Murphy merged commit d50ae11 into official-antistasi-community:unstable Mar 22, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label May 8, 2023
igorkis-scrts pushed a commit to igorkis-scrts/A3-Antistasi-Plus that referenced this pull request Aug 8, 2023
@Bob-Murphy
Merge pull request official-antistasi-community#2671 from killerswin2…
20f04a5 
…/edgecase_minefields

Fix edge case in minefields mine count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bob-Murphy Bob-Murphy Bob-Murphy approved these changes

@Lazejun Lazejun Lazejun approved these changes

Assignees

@CalebSerafin CalebSerafin

@Bob-Murphy Bob-Murphy

Labels
Added to changelog Added to changelog Ready for merge
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

[Bug]: Minefields
4 participants
@killerswin2 @Bob-Murphy @Lazejun @CalebSerafin