Fix HQ position desync #2679
Merged
Fix HQ position desync #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killerswin2
approved these changes
Mar 23, 2023
igorkis-scrts
pushed a commit
to igorkis-scrts/A3-Antistasi-Plus
that referenced
this pull request
Aug 8, 2023
…Q-position-desync Fix HQ position desync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Fixed bug where the two HQ markers (respawnTeamPlayer and "Synd_HQ") could become desynced because placementSelection was setting one of them on the client side for some goddamned reason.
Also stripped out the new-game code from placementSelection (and associated placementDone flag stuff) that was obsoleted by the setup UI HQ placement interface.
The case where the commander disconnects while placing still hasn't been addressed. Quite a lot more work.
Please specify which Issue this PR Resolves.
closes #2675
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
Should do a DS run really as the code has a client/server split, although it should be solid.
How can the changes be tested?
Load or start game, wait 120 seconds for petros to become vulnerable (or run
petros allowDamage true), then get him killed by spawning units in zeus or similar.